diff options
| author | Thomas Huth <thuth@redhat.com> | 2018-03-07 15:22:54 +0100 |
|---|---|---|
| committer | David Gibson <david@gibson.dropbear.id.au> | 2018-03-18 18:27:23 +1100 |
| commit | 1ca15d85ab0d2a53f86a16b75468633938467cd8 (patch) | |
| tree | 746ec5a1d051c03c252bdd48c07375a1af1c8a99 /hw/misc/macio | |
| parent | b891538e81d33e59e1df9ce489e7118b7a1e7857 (diff) | |
| download | focaccia-qemu-1ca15d85ab0d2a53f86a16b75468633938467cd8.tar.gz focaccia-qemu-1ca15d85ab0d2a53f86a16b75468633938467cd8.zip | |
hw/misc/macio: Mark the macio devices with user_creatable = false
The macio devices currently cause a crash when the user tries to instantiate them on a different machine: $ ppc64-softmmu/qemu-system-ppc64 -device macio-newworld Unexpected error in qemu_chr_fe_init() at chardev/char-fe.c:222: qemu-system-ppc64: -device macio-newworld: Device 'serial0' is in use Aborted (core dumped) These devices are clearly not intended to be creatable by the user since they are using serial_hds[] directly in their instance_init function. So let's mark them with user_creatable = false. Signed-off-by: Thomas Huth <thuth@redhat.com> Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Diffstat (limited to 'hw/misc/macio')
| -rw-r--r-- | hw/misc/macio/macio.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/hw/misc/macio/macio.c b/hw/misc/macio/macio.c index af1bd46b4b..454244f59e 100644 --- a/hw/misc/macio/macio.c +++ b/hw/misc/macio/macio.c @@ -406,6 +406,8 @@ static void macio_class_init(ObjectClass *klass, void *data) k->class_id = PCI_CLASS_OTHERS << 8; dc->props = macio_properties; set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories); + /* Reason: Uses serial_hds in macio_instance_init */ + dc->user_creatable = false; } static const TypeInfo macio_oldworld_type_info = { |