diff options
| author | Markus Armbruster <armbru@redhat.com> | 2013-11-28 17:27:02 +0100 |
|---|---|---|
| committer | Andreas Färber <afaerber@suse.de> | 2013-12-23 00:27:23 +0100 |
| commit | f3b176402fa92149320dcd5479916ccb39cfa0a8 (patch) | |
| tree | 297212eb1153bf3f1846f141dcfdcbcacb99bdee /hw/timer/i8254_common.c | |
| parent | 04916ee9fb8ff4be4d9f612b85aef009ec57b0b4 (diff) | |
| download | focaccia-qemu-f3b176402fa92149320dcd5479916ccb39cfa0a8.tar.gz focaccia-qemu-f3b176402fa92149320dcd5479916ccb39cfa0a8.zip | |
isa: Clean up use of cannot_instantiate_with_device_add_yet
Drop it when there's no obvious reason why device_add could not work. Else keep and document why. * isa-fdc: drop * i8042: drop, even though its I/O base is hardcoded (because you could conceivably still add one to a board that has none), and even though PC board code wires up the A20 line (because that wiring is optional) * port92: keep because it needs additional wiring by port92_init() * mc146818rtc: keep because it needs to be wired up by rtc_init() * m48t59_isa: keep because needs to be wired up by m48t59_init_isa() * isa-pit, kvm-pit: keep (in their abstract base pic-common) because the PIT needs additional wiring by board code, depending on HPET presence * pcspk: keep because of pointer property pit, and because realize sets global pcspk_state * vmmouse: keep because of pointer property ps2_mouse * vmport: keep because realize sets global port_state * isa-i8259, kvm-i8259: keep (in their abstract base pic-common), because the PICs' IRQ input lines are set up by board code, and the wiring of the slave to the master is hard-coded in device model code Signed-off-by: Markus Armbruster <armbru@redhat.com> Signed-off-by: Andreas Färber <afaerber@suse.de>
Diffstat (limited to 'hw/timer/i8254_common.c')
| -rw-r--r-- | hw/timer/i8254_common.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/hw/timer/i8254_common.c b/hw/timer/i8254_common.c index dc2196c1ef..9db5c9d129 100644 --- a/hw/timer/i8254_common.c +++ b/hw/timer/i8254_common.c @@ -282,7 +282,12 @@ static void pit_common_class_init(ObjectClass *klass, void *data) dc->realize = pit_common_realize; dc->vmsd = &vmstate_pit_common; - dc->cannot_instantiate_with_device_add_yet = true; /* FIXME explain why */ + /* + * Reason: unlike ordinary ISA devices, the PIT may need to be + * wired to the HPET, and because of that, some wiring is always + * done by board code. + */ + dc->cannot_instantiate_with_device_add_yet = true; } static const TypeInfo pit_common_type = { |