summary refs log tree commit diff stats
path: root/hw/usb/dev-network.c
diff options
context:
space:
mode:
authorEduardo Habkost <ehabkost@redhat.com>2013-01-28 16:15:16 -0200
committerAnthony Liguori <aliguori@us.ibm.com>2013-02-01 10:43:34 -0600
commit6bf0076643dac4f37cabb9233dc9170f1c2fdd49 (patch)
treef95b26883084a5c60bc2730f40b1761834b47855 /hw/usb/dev-network.c
parent3e7b8f4e6f507e09e27b7449f3744596f19c0083 (diff)
downloadfocaccia-qemu-6bf0076643dac4f37cabb9233dc9170f1c2fdd49.tar.gz
focaccia-qemu-6bf0076643dac4f37cabb9233dc9170f1c2fdd49.zip
libqtest: Wait for the right child PID after killing QEMU
When running "make check" with gcov enabled, we get the following
message:

   hw/tmp105.gcda:cannot open data file, assuming not executed

The problem happens because:

 * tmp105-test exits before QEMU exits, because waitpid() at
   qtest_quit() fails;
 * waitpid() fails because there's another process already
   waiting for the QEMU process;
 * The process that is already waiting for QEMU is the child created by
   qtest_init() to run system();
 * qtest_quit() is incorrectly waiting for the QEMU PID directly instead
   of the child created by qtest_init().

This fixes the problem by sending SIGTERM to QEMU, but waiting for the
child process created by qtest_init() (that exits immediately after QEMU
exits).

Reported-by: Andreas Färber <afaerber@suse.de>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Diffstat (limited to 'hw/usb/dev-network.c')
0 files changed, 0 insertions, 0 deletions