summary refs log tree commit diff stats
path: root/hw/usb/host-libusb.c
diff options
context:
space:
mode:
authorPaolo Bonzini <pbonzini@redhat.com>2015-07-14 11:18:06 +0200
committerGerd Hoffmann <kraxel@redhat.com>2015-07-17 08:44:41 +0200
commit562f93754b95fd6dc65ad9a2aa15a90b2da7e8a4 (patch)
tree1a84f3aaa92ab174886266332573e4382c833e1a /hw/usb/host-libusb.c
parente2f6bac3010419426b636d2b307f66deecd60813 (diff)
downloadfocaccia-qemu-562f93754b95fd6dc65ad9a2aa15a90b2da7e8a4.tar.gz
focaccia-qemu-562f93754b95fd6dc65ad9a2aa15a90b2da7e8a4.zip
hid: clarify hid_keyboard_process_keycode
Coverity thinks the fallthroughs are smelly.  They are correct, but
everything else in this function is like "wut?".

Refer explicitly to bits 8 and 9 of hs->kbd.modifiers instead of
shifting right first and using (1 << 7).  Document what the scancode
is when hid_code is 0xe0.  And add plenty of comments.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Diffstat (limited to 'hw/usb/host-libusb.c')
0 files changed, 0 insertions, 0 deletions