diff options
| author | Eduardo Habkost <ehabkost@redhat.com> | 2012-10-15 17:22:02 -0300 |
|---|---|---|
| committer | Blue Swirl <blauwirbel@gmail.com> | 2012-10-20 07:53:28 +0000 |
| commit | 5f072e1f3075bd869e0ace9f2545a85992ac0084 (patch) | |
| tree | 669400d97297f7e73bf3f0e4f35985b85b40fbaf /hw/xen_machine_pv.c | |
| parent | a96d8bea8e23473bd5b4b4111ba9187fcb976865 (diff) | |
| download | focaccia-qemu-5f072e1f3075bd869e0ace9f2545a85992ac0084.tar.gz focaccia-qemu-5f072e1f3075bd869e0ace9f2545a85992ac0084.zip | |
create struct for machine initialization arguments
This should help us to: - More easily add or remove machine initialization arguments without having to change every single machine init function; - More easily make mechanical changes involving the machine init functions in the future; - Let machine initialization forward the init arguments to other functions more easily. This change was half-mechanical process: first the struct was added with the local ram_size, boot_device, kernel_*, initrd_*, and cpu_model local variable initialization to all functions. Then the compiler helped me locate the local variables that are unused, so they could be removed. Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
Diffstat (limited to 'hw/xen_machine_pv.c')
| -rw-r--r-- | hw/xen_machine_pv.c | 11 |
1 files changed, 5 insertions, 6 deletions
diff --git a/hw/xen_machine_pv.c b/hw/xen_machine_pv.c index 4b72aa7557..426470351e 100644 --- a/hw/xen_machine_pv.c +++ b/hw/xen_machine_pv.c @@ -29,13 +29,12 @@ #include "xen_domainbuild.h" #include "blockdev.h" -static void xen_init_pv(ram_addr_t ram_size, - const char *boot_device, - const char *kernel_filename, - const char *kernel_cmdline, - const char *initrd_filename, - const char *cpu_model) +static void xen_init_pv(QEMUMachineInitArgs *args) { + const char *cpu_model = args->cpu_model; + const char *kernel_filename = args->kernel_filename; + const char *kernel_cmdline = args->kernel_cmdline; + const char *initrd_filename = args->initrd_filename; X86CPU *cpu; CPUX86State *env; DriveInfo *dinfo; |