diff options
| author | Igor Mammedov <imammedo@redhat.com> | 2016-05-19 15:19:30 +0200 |
|---|---|---|
| committer | Michael S. Tsirkin <mst@redhat.com> | 2016-06-07 15:39:27 +0300 |
| commit | 28213cb6a61a724e2cb1e3a76d2bb17aa0ce9b36 (patch) | |
| tree | 3d19dc5c51a53dd776bf532db8861ad0fe7068a1 /include/hw/acpi | |
| parent | 4678124bb9bfb49e93b83f95c4d2feeb443ea38b (diff) | |
| download | focaccia-qemu-28213cb6a61a724e2cb1e3a76d2bb17aa0ce9b36.tar.gz focaccia-qemu-28213cb6a61a724e2cb1e3a76d2bb17aa0ce9b36.zip | |
acpi: make bios_linker_loader_add_checksum() API offset based
It should help to make clear that bios_linker works in terms of offsets within a file. Also it should prevent mistakes where user passes as arguments pointers to unrelated to file blobs. While at it, considering that it's a ACPI checksum and it's initial value must be 0, move checksum field zeroing into bios_linker_loader_add_checksum() instead of doing it at every call site manually before bios_linker_loader_add_checksum() is called. In addition add extra boundary checks. Signed-off-by: Igor Mammedov <imammedo@redhat.com> Reviewed-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Diffstat (limited to 'include/hw/acpi')
| -rw-r--r-- | include/hw/acpi/bios-linker-loader.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/include/hw/acpi/bios-linker-loader.h b/include/hw/acpi/bios-linker-loader.h index f666b7c81c..a05227eb30 100644 --- a/include/hw/acpi/bios-linker-loader.h +++ b/include/hw/acpi/bios-linker-loader.h @@ -17,8 +17,8 @@ void bios_linker_loader_alloc(BIOSLinker *linker, bool alloc_fseg); void bios_linker_loader_add_checksum(BIOSLinker *linker, const char *file, - void *start, unsigned size, - uint8_t *checksum); + unsigned start_offset, unsigned size, + unsigned checksum_offset); void bios_linker_loader_add_pointer(BIOSLinker *linker, const char *dest_file, |