summary refs log tree commit diff stats
path: root/include/hw/qdev-properties.h
diff options
context:
space:
mode:
authorRaphael Norwitz <raphael.norwitz@nutanix.com>2020-01-15 21:57:04 -0500
committerMichael S. Tsirkin <mst@redhat.com>2020-02-27 03:46:10 -0500
commitb844a4c77b618acfba6b3f4ce12d2ad709f99279 (patch)
tree7dde6573935f4ff82ca2de15b8a71acd65033ffa /include/hw/qdev-properties.h
parent67b3965e89f8466fc6a61caa2142dd2c89257383 (diff)
downloadfocaccia-qemu-b844a4c77b618acfba6b3f4ce12d2ad709f99279.tar.gz
focaccia-qemu-b844a4c77b618acfba6b3f4ce12d2ad709f99279.zip
Fixed assert in vhost_user_set_mem_table_postcopy
The current vhost_user_set_mem_table_postcopy() implementation
populates each region of the VHOST_USER_SET_MEM_TABLE message without
first checking if there are more than VHOST_MEMORY_MAX_NREGIONS already
populated. This can cause memory corruption if too many regions are
added to the message during the postcopy step.

This change moves an existing assert up such that attempting to
construct a VHOST_USER_SET_MEM_TABLE message with too many memory
regions will gracefully bring down qemu instead of corrupting memory.

Signed-off-by: Raphael Norwitz <raphael.norwitz@nutanix.com>
Signed-off-by: Peter Turschmid <peter.turschm@nutanix.com>
Message-Id: <1579143426-18305-2-git-send-email-raphael.norwitz@nutanix.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Diffstat (limited to 'include/hw/qdev-properties.h')
0 files changed, 0 insertions, 0 deletions