diff options
| author | Damien Hedde <damien.hedde@greensocs.com> | 2020-01-30 16:02:04 +0000 |
|---|---|---|
| committer | Peter Maydell <peter.maydell@linaro.org> | 2020-01-30 16:02:04 +0000 |
| commit | e755e12759e91a013e417a438305b133ea3c2d19 (patch) | |
| tree | 92ff35196775d1e82b52ef61c02dde54718afa67 /include/hw/resettable.h | |
| parent | a7c3a4f986dd2becca5fa11dd7e6eba81b596d06 (diff) | |
| download | focaccia-qemu-e755e12759e91a013e417a438305b133ea3c2d19.tar.gz focaccia-qemu-e755e12759e91a013e417a438305b133ea3c2d19.zip | |
hw/core/qdev: update hotplug reset regarding resettable
This commit make use of the resettable API to reset the device being hotplugged when it is realized. Also it ensures it is put in a reset state coherent with the parent it is plugged into. Note that there is a difference in the reset. Instead of resetting only the hotplugged device, we reset also its subtree (switch to resettable API). This is not expected to be a problem because sub-buses are just realized too. If a hotplugged device has any sub-buses it is logical to reset them too at this point. The recently added should_be_hidden and PCI's partially_hotplugged mechanisms do not interfere with realize operation: + In the should_be_hidden use case, device creation is delayed. + The partially_hotplugged mechanism prevents a device to be unplugged and unrealized from qdev POV and unrealized. Signed-off-by: Damien Hedde <damien.hedde@greensocs.com> Reviewed-by: Richard Henderson <richard.henderson@linaro.org> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com> Message-id: 20200123132823.1117486-8-damien.hedde@greensocs.com Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Diffstat (limited to 'include/hw/resettable.h')
| -rw-r--r-- | include/hw/resettable.h | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/include/hw/resettable.h b/include/hw/resettable.h index 96073354fd..5e215d94e4 100644 --- a/include/hw/resettable.h +++ b/include/hw/resettable.h @@ -154,6 +154,17 @@ struct ResettableState { }; /** + * resettable_state_clear: + * Clear the state. It puts the state to the initial (zeroed) state required + * to reuse an object. Typically used in realize step of base classes + * implementing the interface. + */ +static inline void resettable_state_clear(ResettableState *state) +{ + memset(state, 0, sizeof(ResettableState)); +} + +/** * resettable_reset: * Trigger a reset on an object @obj of type @type. @obj must implement * Resettable interface. |