diff options
| author | Vitaly Kuznetsov <vkuznets@redhat.com> | 2024-12-12 14:45:04 +0100 |
|---|---|---|
| committer | Kevin Wolf <kwolf@redhat.com> | 2025-02-06 13:59:00 +0100 |
| commit | 558d8eb7f32dda8634e0d3e82ac36e00bf61c9ee (patch) | |
| tree | 0949c347b1d1d7a175be735315cd1842335a9112 /include/system/block-backend-io.h | |
| parent | c5f28995b8fe52be02f400765694203bc6b94904 (diff) | |
| download | focaccia-qemu-558d8eb7f32dda8634e0d3e82ac36e00bf61c9ee.tar.gz focaccia-qemu-558d8eb7f32dda8634e0d3e82ac36e00bf61c9ee.zip | |
vpc: Read images exported from Azure correctly
It was found that 'qemu-nbd' is not able to work with some disk images exported from Azure. Looking at the 512b footer (which contains VPC metadata): 00000000 63 6f 6e 65 63 74 69 78 00 00 00 02 00 01 00 00 |conectix........| 00000010 ff ff ff ff ff ff ff ff 2e c7 9b 96 77 61 00 00 |............wa..| 00000020 00 07 00 00 57 69 32 6b 00 00 00 01 40 00 00 00 |....Wi2k....@...| 00000030 00 00 00 01 40 00 00 00 28 a2 10 3f 00 00 00 02 |....@...(..?....| 00000040 ff ff e7 47 8c 54 df 94 bd 35 71 4c 94 5f e5 44 |...G.T...5qL._.D| 00000050 44 53 92 1a 00 00 00 00 00 00 00 00 00 00 00 00 |DS..............| 00000060 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| we can see that Azure uses a different 'Creator application' -- 'wa\0\0' (offset 0x1c, likely reads as 'Windows Azure') and QEMU uses this field to determine how it can get image size. Apparently, Azure uses 'new' method, just like Hyper-V. Overall, it seems that only VPC and old QEMUs need to be ignored as all new creator apps seem to have reliable current_size. Invert the logic and make 'current_size' method the default to avoid adding every new creator app to the list. Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com> Message-ID: <20241212134504.1983757-3-vkuznets@redhat.com> Reviewed-by: Kevin Wolf <kwolf@redhat.com> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'include/system/block-backend-io.h')
0 files changed, 0 insertions, 0 deletions