diff options
| author | Gerd Hoffmann <kraxel@redhat.com> | 2013-02-28 11:34:31 +0100 |
|---|---|---|
| committer | Gerd Hoffmann <kraxel@redhat.com> | 2013-03-18 10:21:58 +0100 |
| commit | 21ef45d71221b4577330fe3aacfb06afad91ad46 (patch) | |
| tree | 80e7115e65cce66068a720a1247ad2939066bf57 /include/ui/console.h | |
| parent | 7c20b4a374d0016e3fce005690fb428354a56621 (diff) | |
| download | focaccia-qemu-21ef45d71221b4577330fe3aacfb06afad91ad46.tar.gz focaccia-qemu-21ef45d71221b4577330fe3aacfb06afad91ad46.zip | |
console: kill DisplayState->opaque
It's broken by design. There can be multiple DisplayChangeListener instances, so they simply can't store state in the (single) DisplayState struct. Try 'qemu -display gtk -vnc :0', watch it crash & burn. With DisplayChangeListenerOps having a more sane interface now we can simply use the DisplayChangeListener pointer to get access to our private data instead. Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Diffstat (limited to 'include/ui/console.h')
| -rw-r--r-- | include/ui/console.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/include/ui/console.h b/include/ui/console.h index bf54f1ea54..91a1f63e5d 100644 --- a/include/ui/console.h +++ b/include/ui/console.h @@ -193,7 +193,6 @@ struct DisplayChangeListener { struct DisplayState { struct DisplaySurface *surface; - void *opaque; struct QEMUTimer *gui_timer; bool have_gfx; bool have_text; |