diff options
| author | Hanna Reitz <hreitz@redhat.com> | 2021-10-06 17:19:37 +0200 |
|---|---|---|
| committer | Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> | 2021-10-07 10:42:50 +0200 |
| commit | 4feeec7e23b4151c962cb1b9f1a0e403803dfaee (patch) | |
| tree | e8bcf7cc8fd87263956c4988356ca1bb5808206d /job.c | |
| parent | 20ad4d204accb27346b05b046ee8225c6725ef49 (diff) | |
| download | focaccia-qemu-4feeec7e23b4151c962cb1b9f1a0e403803dfaee.tar.gz focaccia-qemu-4feeec7e23b4151c962cb1b9f1a0e403803dfaee.zip | |
mirror: Check job_is_cancelled() earlier
We must check whether the job is force-cancelled early in our main loop, most importantly before any `continue` statement. For example, we used to have `continue`s before our current checking location that are triggered by `mirror_flush()` failing. So, if `mirror_flush()` kept failing, force-cancelling the job would not terminate it. Jobs can be cancelled while they yield, and once they are (force-cancelled), they should not generate new I/O requests. Therefore, we should put the check after the last yield before mirror_iteration() is invoked. Buglink: https://gitlab.com/qemu-project/qemu/-/issues/462 Signed-off-by: Hanna Reitz <hreitz@redhat.com> Reviewed-by: Eric Blake <eblake@redhat.com> Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> Message-Id: <20211006151940.214590-11-hreitz@redhat.com> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Diffstat (limited to 'job.c')
0 files changed, 0 insertions, 0 deletions