summary refs log tree commit diff stats
path: root/linux-user/m68k/cpu_loop.c
diff options
context:
space:
mode:
authorMarc-André Lureau <marcandre.lureau@redhat.com>2018-09-07 10:36:34 +0400
committerGerd Hoffmann <kraxel@redhat.com>2018-10-01 11:29:03 +0200
commitb5dc0d7d565048fcf2767060261d8385805aced1 (patch)
tree93042f7285976715a5b34ee1834eb517bf6fd0a7 /linux-user/m68k/cpu_loop.c
parent6624c38d11d0bdb45579c3cc8c7499af79b20564 (diff)
downloadfocaccia-qemu-b5dc0d7d565048fcf2767060261d8385805aced1.tar.gz
focaccia-qemu-b5dc0d7d565048fcf2767060261d8385805aced1.zip
vnc: call sasl_server_init() only when required
VNC server is calling sasl_server_init() during startup of QEMU, even
if SASL auth has not been enabled.

This may create undesirable warnings like "Could not find keytab file:
/etc/qemu/krb5.tab" when the user didn't configure SASL on host and
started VNC server.

Instead, only initialize SASL when needed. Note that HMP/QMP "change
vnc" calls vnc_display_open() again, which will initialize SASL if
needed.

Fix assignment in if condition, while touching this code.

Related to:
https://bugzilla.redhat.com/show_bug.cgi?id=1609327

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-id: 20180907063634.359-1-marcandre.lureau@redhat.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Diffstat (limited to 'linux-user/m68k/cpu_loop.c')
0 files changed, 0 insertions, 0 deletions