diff options
| author | Peter Maydell <peter.maydell@linaro.org> | 2018-10-19 17:17:15 +0100 |
|---|---|---|
| committer | Laurent Vivier <laurent@vivier.eu> | 2018-11-12 15:43:07 +0100 |
| commit | e285977e77e534f128413b86cabab68bbffcbe4c (patch) | |
| tree | 862cacd86f1987052f14e2ebfc65531e9eaf13ac /linux-user/sparc | |
| parent | b4c0595446cda9252d2c7bc84f3c02f3e591935a (diff) | |
| download | focaccia-qemu-e285977e77e534f128413b86cabab68bbffcbe4c.tar.gz focaccia-qemu-e285977e77e534f128413b86cabab68bbffcbe4c.zip | |
linux-user: Remove dead error-checking code
Remove some dead code spotted by Coverity (CID 1009855, 1390854, 1390847). The underlying cause in all these cases is the same: QEMU's put_user operations can't result in errors, but the kernel's equivalent does. So when code was copied from the kernel signal-frame-setup/teardown code, checks on error flags that were needed in the kernel became dead code for us. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Laurent Vivier <laurent@vivier.eu> Message-Id: <20181019161715.12122-1-peter.maydell@linaro.org> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
Diffstat (limited to 'linux-user/sparc')
| -rw-r--r-- | linux-user/sparc/signal.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/linux-user/sparc/signal.c b/linux-user/sparc/signal.c index e44e99993c..295e415b1e 100644 --- a/linux-user/sparc/signal.c +++ b/linux-user/sparc/signal.c @@ -256,8 +256,6 @@ void setup_frame(int sig, struct target_sigaction *ka, /* t 0x10 */ val32 = 0x91d02010; __put_user(val32, &sf->insns[1]); - if (err) - goto sigsegv; } unlock_user(sf, sf_addr, sizeof(struct target_signal_frame)); return; |