summary refs log tree commit diff stats
path: root/monitor/qmp.c
diff options
context:
space:
mode:
authorPaolo Bonzini <pbonzini@redhat.com>2023-03-03 13:32:13 +0100
committerPaolo Bonzini <pbonzini@redhat.com>2023-05-25 10:18:33 +0200
commit6ee7c82d0df9bb6e972a8ea689b935df3ba37486 (patch)
treef99a5786fb54b9072069e498313d4336bd9aaa6a /monitor/qmp.c
parent4cb96b974265f97a9902b4458e50d01082572a16 (diff)
downloadfocaccia-qemu-6ee7c82d0df9bb6e972a8ea689b935df3ba37486.tar.gz
focaccia-qemu-6ee7c82d0df9bb6e972a8ea689b935df3ba37486.zip
monitor: do not use mb_read/mb_set for suspend_cnt
Clean up monitor_event to just use monitor_suspend/monitor_resume,
using mon->mux_out to protect against incorrect nesting (especially
on startup).

The only remaining case of reading suspend_cnt is in the can_read
callback, which is just advisory and can use qatomic_read.

As an extra benefit, mux_out is now simply protected by mon_lock.
Also, moving the prompt to the beginning of the main loop removes
it from the output in some error cases where QEMU does not actually
start successfully.  It is not a full fix and it would be nice to
also remove the monitor heading, but this is already a small (though
unintentional) improvement.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'monitor/qmp.c')
0 files changed, 0 insertions, 0 deletions