summary refs log tree commit diff stats
path: root/net/l2tpv3.c
diff options
context:
space:
mode:
authorAlexey Kirillov <lekiravi@yandex-team.ru>2021-03-03 12:59:08 +0300
committerJason Wang <jasowang@redhat.com>2021-03-15 16:41:22 +0800
commit59b5437eb732d6b103a9bc279c3482c834d1eff9 (patch)
tree9f0667074f09bf4fe8f7ac904a030e72189d9774 /net/l2tpv3.c
parent3c3b656885473ef0d699290ba966177f17839aa5 (diff)
downloadfocaccia-qemu-59b5437eb732d6b103a9bc279c3482c834d1eff9.tar.gz
focaccia-qemu-59b5437eb732d6b103a9bc279c3482c834d1eff9.zip
net: Move NetClientState.info_str to dynamic allocations
The info_str field of the NetClientState structure is static and has a size
of 256 bytes. This amount is often unclaimed, and the field itself is used
exclusively for HMP "info network".

The patch translates info_str to dynamic memory allocation.

This action is also allows us to painlessly discard usage of this field
for backend devices.

Signed-off-by: Alexey Kirillov <lekiravi@yandex-team.ru>
Signed-off-by: Jason Wang <jasowang@redhat.com>
Diffstat (limited to 'net/l2tpv3.c')
-rw-r--r--net/l2tpv3.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/net/l2tpv3.c b/net/l2tpv3.c
index 8aa0a3e1a0..96611cb4af 100644
--- a/net/l2tpv3.c
+++ b/net/l2tpv3.c
@@ -730,8 +730,7 @@ int net_init_l2tpv3(const Netdev *netdev,
     QAPI_CLONE_MEMBERS(NetdevL2TPv3Options,
                        &nc->stored_config->u.l2tpv3, l2tpv3);
 
-    snprintf(s->nc.info_str, sizeof(s->nc.info_str),
-             "l2tpv3: connected");
+    s->nc.info_str = g_strdup_printf("l2tpv3: connected");
     return 0;
 outerr:
     qemu_del_net_client(nc);