summary refs log tree commit diff stats
path: root/net/socket.c
diff options
context:
space:
mode:
authorMarkus Armbruster <armbru@redhat.com>2018-10-17 10:26:35 +0200
committerMarkus Armbruster <armbru@redhat.com>2018-10-19 14:51:34 +0200
commit1028283c60e6e35911bb80b959a533b4af1b8b65 (patch)
tree392fec3e8109c797cf47c5e21bad4c229f8fadd7 /net/socket.c
parent11ab69d6e7a81c35f109a399a39d56e777f41d8a (diff)
downloadfocaccia-qemu-1028283c60e6e35911bb80b959a533b4af1b8b65.tar.gz
focaccia-qemu-1028283c60e6e35911bb80b959a533b4af1b8b65.zip
smbios: Clean up error handling in smbios_add()
Calling error_report() in a function that takes an Error ** argument
is suspicious.  smbios_entry_add() does that, and then exit()s.  It
also passes &error_fatal to qemu_opts_validate().  Both wrong, but
currently harmless, as its only caller passes &error_fatal.  Messed up
in commit 1007a37e208.  Clean it up.

Cc: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20181017082702.5581-12-armbru@redhat.com>
Diffstat (limited to 'net/socket.c')
0 files changed, 0 insertions, 0 deletions