diff options
| author | Alexey Kirillov <lekiravi@yandex-team.ru> | 2021-03-03 12:59:08 +0300 |
|---|---|---|
| committer | Jason Wang <jasowang@redhat.com> | 2021-03-15 16:41:22 +0800 |
| commit | 59b5437eb732d6b103a9bc279c3482c834d1eff9 (patch) | |
| tree | 9f0667074f09bf4fe8f7ac904a030e72189d9774 /net/tap-win32.c | |
| parent | 3c3b656885473ef0d699290ba966177f17839aa5 (diff) | |
| download | focaccia-qemu-59b5437eb732d6b103a9bc279c3482c834d1eff9.tar.gz focaccia-qemu-59b5437eb732d6b103a9bc279c3482c834d1eff9.zip | |
net: Move NetClientState.info_str to dynamic allocations
The info_str field of the NetClientState structure is static and has a size of 256 bytes. This amount is often unclaimed, and the field itself is used exclusively for HMP "info network". The patch translates info_str to dynamic memory allocation. This action is also allows us to painlessly discard usage of this field for backend devices. Signed-off-by: Alexey Kirillov <lekiravi@yandex-team.ru> Signed-off-by: Jason Wang <jasowang@redhat.com>
Diffstat (limited to 'net/tap-win32.c')
| -rw-r--r-- | net/tap-win32.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/net/tap-win32.c b/net/tap-win32.c index b60933bd1a..0888db8cce 100644 --- a/net/tap-win32.c +++ b/net/tap-win32.c @@ -787,8 +787,7 @@ static int tap_win32_init(NetClientState *peer, const char *model, stored->has_ifname = true; stored->ifname = g_strdup(ifname); - snprintf(s->nc.info_str, sizeof(s->nc.info_str), - "tap: ifname=%s", ifname); + s->nc.info_str = g_strdup_printf("tap: ifname=%s", ifname); s->handle = handle; |