diff options
| author | John Snow <jsnow@redhat.com> | 2022-02-25 15:59:48 -0500 |
|---|---|---|
| committer | John Snow <jsnow@redhat.com> | 2022-03-07 14:36:41 -0500 |
| commit | 4c1fe7003c9b373acb0791b4356e2285a10365c0 (patch) | |
| tree | b387afa45b25cf0b001d0b6be0268f5d3cee1df6 /python/qemu/aqmp/legacy.py | |
| parent | 673856f9d889dc50b6a1a7964df960c4f00c7c93 (diff) | |
| download | focaccia-qemu-4c1fe7003c9b373acb0791b4356e2285a10365c0.tar.gz focaccia-qemu-4c1fe7003c9b373acb0791b4356e2285a10365c0.zip | |
python/aqmp: drop _bind_hack()
_bind_hack() was a quick fix to allow async QMP to call bind(2) prior to calling listen(2) and accept(2). This wasn't sufficient to fully address the race condition present in synchronous clients. With the race condition in legacy.py fixed (see the previous commit), there are no longer any users of _bind_hack(). Drop it. Fixes: b0b662bb2b3 Signed-off-by: John Snow <jsnow@redhat.com> Acked-by: Kevin Wolf <kwolf@redhat.com> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> Message-id: 20220225205948.3693480-11-jsnow@redhat.com [Expanded commit message. --js] Signed-off-by: John Snow <jsnow@redhat.com>
Diffstat (limited to 'python/qemu/aqmp/legacy.py')
| -rw-r--r-- | python/qemu/aqmp/legacy.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/python/qemu/aqmp/legacy.py b/python/qemu/aqmp/legacy.py index cb50e60564..46026e9fdc 100644 --- a/python/qemu/aqmp/legacy.py +++ b/python/qemu/aqmp/legacy.py @@ -57,7 +57,7 @@ class QEMUMonitorProtocol(qemu.qmp.QEMUMonitorProtocol): self._timeout: Optional[float] = None if server: - self._sync(self._aqmp.start_server(address)) + self._sync(self._aqmp.start_server(self._address)) _T = TypeVar('_T') |