summary refs log tree commit diff stats
path: root/qemu-io-cmds.c
diff options
context:
space:
mode:
authorHanna Reitz <hreitz@redhat.com>2022-06-20 18:26:53 +0200
committerKevin Wolf <kwolf@redhat.com>2023-02-01 16:52:32 +0100
commit3716470b24f0f63090d59bcf28ad8fe6fb7835bd (patch)
treeb697430a0cb2706f27dd90b1a3ca2314d069803c /qemu-io-cmds.c
parentfcb9e05144db51966e1476790129dbff92a0bea4 (diff)
downloadfocaccia-qemu-3716470b24f0f63090d59bcf28ad8fe6fb7835bd.tar.gz
focaccia-qemu-3716470b24f0f63090d59bcf28ad8fe6fb7835bd.zip
block: Improve empty format-specific info dump
When a block driver supports obtaining format-specific information, but
that object only contains optional fields, it is possible that none of
them are present, so that dump_qobject() (called by
bdrv_image_info_specific_dump()) will not print anything.

The callers of bdrv_image_info_specific_dump() put a header above this
information ("Format specific information:\n"), which will look strange
when there is nothing below.  Modify bdrv_image_info_specific_dump() to
print this header instead of its callers, and only if there is indeed
something to be printed.

Signed-off-by: Hanna Reitz <hreitz@redhat.com>
Message-Id: <20220620162704.80987-2-hreitz@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'qemu-io-cmds.c')
-rw-r--r--qemu-io-cmds.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/qemu-io-cmds.c b/qemu-io-cmds.c
index 7a412d6512..d7e562dda6 100644
--- a/qemu-io-cmds.c
+++ b/qemu-io-cmds.c
@@ -1788,8 +1788,8 @@ static int info_f(BlockBackend *blk, int argc, char **argv)
         return -EIO;
     }
     if (spec_info) {
-        printf("Format specific information:\n");
-        bdrv_image_info_specific_dump(spec_info);
+        bdrv_image_info_specific_dump(spec_info,
+                                      "Format specific information:\n");
         qapi_free_ImageInfoSpecific(spec_info);
     }