summary refs log tree commit diff stats
path: root/qemu-io-cmds.c
diff options
context:
space:
mode:
authorKevin Wolf <kwolf@redhat.com>2015-02-10 14:25:02 +0100
committerStefan Hajnoczi <stefanha@redhat.com>2015-02-16 15:07:17 +0000
commit5d80448c3fc566e505adfa2b566ec8074442c8e1 (patch)
tree1305c8cf091f65eebeac8be707c681b59cc779db /qemu-io-cmds.c
parent141cabe6f144a1acb128186caf686f8fbde0a7e4 (diff)
downloadfocaccia-qemu-5d80448c3fc566e505adfa2b566ec8074442c8e1.tar.gz
focaccia-qemu-5d80448c3fc566e505adfa2b566ec8074442c8e1.zip
savevm: Improve error message for blocked migration
If an internal snapshot can't be saved because migration is blocked
(most commonly probably because of AHCI), we had a really bad error
message:

$ echo -e "savevm foo\nquit" | qemu -M q35 /tmp/test.qcow2 -monitor stdio
QEMU 2.2.50 monitor - type 'help' for more information
(qemu) savevm foo
Error -22 while writing VM
(qemu) quit

This patch converts qemu_savevm_state() to the Error infrastructure so
that a useful error pointing to the problematic device is produced now:

$ echo -e "savevm foo\nquit" | qemu -M q35 /tmp/test.qcow2 -monitor stdio
QEMU 2.2.50 monitor - type 'help' for more information
(qemu) savevm foo
State blocked by non-migratable device '0000:00:1f.2/ich9_ahci'
(qemu) quit

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-id: 1423574702-23072-1-git-send-email-kwolf@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Diffstat (limited to 'qemu-io-cmds.c')
0 files changed, 0 insertions, 0 deletions