summary refs log tree commit diff stats
path: root/qga/commands.c
diff options
context:
space:
mode:
authorLuiz Capitulino <lcapitulino@redhat.com>2012-05-14 15:25:20 -0300
committerMichael Roth <mdroth@linux.vnet.ibm.com>2012-05-15 09:15:16 -0500
commit3674838cd05268954bb6473239cd7f700a79bf0f (patch)
tree87b737a98ccd7ed630197b3c5fa094170e6d8160 /qga/commands.c
parentd5dd3498ebf4d6dc8661f6a9a69ae10b50f3a6a6 (diff)
downloadfocaccia-qemu-3674838cd05268954bb6473239cd7f700a79bf0f.tar.gz
focaccia-qemu-3674838cd05268954bb6473239cd7f700a79bf0f.zip
qemu-ga: guest-shutdown: use only async-signal-safe functions
POSIX mandates[1] that a child process of a multi-thread program uses
only async-signal-safe functions before exec(). We consider qemu-ga
to be multi-thread, because it uses glib.

However, qmp_guest_shutdown() uses functions that are not
async-signal-safe. Fix it the following way:

- fclose() -> reopen_fd_to_null()
- execl() -> execle()
- exit() -> _exit()
- drop slog() usage (which is not safe)

  [1] http://pubs.opengroup.org/onlinepubs/009695399/functions/fork.html

Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Diffstat (limited to 'qga/commands.c')
0 files changed, 0 insertions, 0 deletions