summary refs log tree commit diff stats
path: root/qga/guest-agent-command-state.c
diff options
context:
space:
mode:
authorMarkus Armbruster <armbru@redhat.com>2015-09-14 13:50:44 +0200
committerMichael Roth <mdroth@linux.vnet.ibm.com>2015-10-19 18:28:06 -0500
commitf3a06403b82c7f036564e4caf18b52ce6885fcfb (patch)
treeb44a6798691f6b40575983d264b8ea153dfd04e2 /qga/guest-agent-command-state.c
parentfafcaf1d7434bd3a44a5cd6a98594b3ec12d83de (diff)
downloadfocaccia-qemu-f3a06403b82c7f036564e4caf18b52ce6885fcfb.tar.gz
focaccia-qemu-f3a06403b82c7f036564e4caf18b52ce6885fcfb.zip
qga: Use g_new() & friends where that makes obvious sense
g_new(T, n) is neater than g_malloc(sizeof(T) * n).  It's also safer,
for two reasons.  One, it catches multiplication overflowing size_t.
Two, it returns T * rather than void *, which lets the compiler catch
more type errors.

This commit only touches allocations with size arguments of the form
sizeof(T).  Same Coccinelle semantic patch as in commit b45c03f.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Diffstat (limited to 'qga/guest-agent-command-state.c')
-rw-r--r--qga/guest-agent-command-state.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/qga/guest-agent-command-state.c b/qga/guest-agent-command-state.c
index 969da23282..128c549edb 100644
--- a/qga/guest-agent-command-state.c
+++ b/qga/guest-agent-command-state.c
@@ -27,7 +27,7 @@ void ga_command_state_add(GACommandState *cs,
                           void (*init)(void),
                           void (*cleanup)(void))
 {
-    GACommandGroup *cg = g_malloc0(sizeof(GACommandGroup));
+    GACommandGroup *cg = g_new0(GACommandGroup, 1);
     cg->init = init;
     cg->cleanup = cleanup;
     cs->groups = g_slist_append(cs->groups, cg);
@@ -67,7 +67,7 @@ void ga_command_state_cleanup_all(GACommandState *cs)
 
 GACommandState *ga_command_state_new(void)
 {
-    GACommandState *cs = g_malloc0(sizeof(GACommandState));
+    GACommandState *cs = g_new0(GACommandState, 1);
     cs->groups = NULL;
     return cs;
 }