summary refs log tree commit diff stats
path: root/scripts/block-coroutine-wrapper.py
diff options
context:
space:
mode:
authorKevin Wolf <kwolf@redhat.com>2023-01-12 20:14:53 +0100
committerKevin Wolf <kwolf@redhat.com>2023-01-24 18:26:41 +0100
commitc5e477110dcb8ef4642dce399777c3dee68fa96c (patch)
tree641815563c130f400870e5df8d66bee138cce98b /scripts/block-coroutine-wrapper.py
parent44efba2d713aca076c411594d0c1a2b99155eeb3 (diff)
downloadfocaccia-qemu-c5e477110dcb8ef4642dce399777c3dee68fa96c.tar.gz
focaccia-qemu-c5e477110dcb8ef4642dce399777c3dee68fa96c.zip
qemu-img bitmap: Report errors while closing the image
blk_unref() can't report any errors that happen while closing the image.
For example, if qcow2 hits an -ENOSPC error while writing out dirty
bitmaps when it's closed, it prints error messages to stderr, but
'qemu-img bitmap' won't see any error return value and will therefore
look successful with exit code 0.

In order to fix this, manually inactivate the image first before calling
blk_unref(). This already performs the operations that would be most
likely to fail while closing the image, but it can still return errors.

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1330
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Message-Id: <20230112191454.169353-4-kwolf@redhat.com>
Reviewed-by: Hanna Czenczek <hreitz@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'scripts/block-coroutine-wrapper.py')
0 files changed, 0 insertions, 0 deletions