diff options
| author | Pierrick Bouvier <pierrick.bouvier@linaro.org> | 2025-01-16 16:02:52 +0000 |
|---|---|---|
| committer | Alex Bennée <alex.bennee@linaro.org> | 2025-01-17 10:45:13 +0000 |
| commit | 8f5a4cfc7ed9e06e07fdd8e8fdf50ef3ea783f63 (patch) | |
| tree | 74b56b3b801e7e0d74fb1c236bf13634224e286c /scripts/cocci-macro-file.h | |
| parent | 27f347e6a1d269c533633c812321cabb249eada8 (diff) | |
| download | focaccia-qemu-8f5a4cfc7ed9e06e07fdd8e8fdf50ef3ea783f63.tar.gz focaccia-qemu-8f5a4cfc7ed9e06e07fdd8e8fdf50ef3ea783f63.zip | |
win32: remove usage of attribute gcc_struct
This attribute is not recognized by clang. An investigation has been performed to ensure this attribute has no effect on layout of structures we use in QEMU [1], so it's safe to remove now. In the future, we'll forbid introducing new bitfields in packed struct, as they are the one potentially impacted by this change. [1] https://lore.kernel.org/qemu-devel/66c346de-7e20-4831-b3eb-1cda83240af9@linaro.org/ Reviewed-by: Thomas Huth <thuth@redhat.com> Reviewed-by: Richard Henderson <richard.henderson@linaro.org> Acked-by: Stefano Garzarella <sgarzare@redhat.com> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org> Acked-by: Michael S. Tsirkin <mst@redhat.com> Tested-by: Stefan Weil <sw@weilnetz.de> Tested-by: Philippe Mathieu-Daudé <philmd@linaro.org> Message-Id: <20250110203401.178532-2-pierrick.bouvier@linaro.org> Signed-off-by: Alex Bennée <alex.bennee@linaro.org> Message-Id: <20250116160306.1709518-24-alex.bennee@linaro.org>
Diffstat (limited to 'scripts/cocci-macro-file.h')
| -rw-r--r-- | scripts/cocci-macro-file.h | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/scripts/cocci-macro-file.h b/scripts/cocci-macro-file.h index d247a5086e..c64831d540 100644 --- a/scripts/cocci-macro-file.h +++ b/scripts/cocci-macro-file.h @@ -23,11 +23,7 @@ #define G_GNUC_WARN_UNUSED_RESULT __attribute__((warn_unused_result)) #define G_GNUC_NULL_TERMINATED __attribute__((sentinel)) -#if defined(_WIN32) && (defined(__x86_64__) || defined(__i386__)) -# define QEMU_PACKED __attribute__((gcc_struct, packed)) -#else -# define QEMU_PACKED __attribute__((packed)) -#endif +#define QEMU_PACKED __attribute__((packed)) #define cat(x,y) x ## y #define cat2(x,y) cat(x,y) |