summary refs log tree commit diff stats
path: root/scripts/decodetree.py
diff options
context:
space:
mode:
authorEric Blake <eblake@redhat.com>2023-06-08 08:56:36 -0500
committerEric Blake <eblake@redhat.com>2023-07-19 15:26:13 -0500
commit70fa99f445a6fabe4b46f188cc665cd469cd8293 (patch)
tree7a258a28ea076d84ad7092edef18f9756d9c2002 /scripts/decodetree.py
parent8cb98a725e7397c9de25ebd77c00b1d5f2d8351e (diff)
downloadfocaccia-qemu-70fa99f445a6fabe4b46f188cc665cd469cd8293.tar.gz
focaccia-qemu-70fa99f445a6fabe4b46f188cc665cd469cd8293.zip
nbd/client: Add safety check on chunk payload length
Our existing use of structured replies either reads into a qiov capped
at 32M (NBD_CMD_READ) or caps allocation to 1000 bytes (see
NBD_MAX_MALLOC_PAYLOAD in block/nbd.c).  But the existing length
checks are rather late; if we encounter a buggy (or malicious) server
that sends a super-large payload length, we should drop the connection
right then rather than assuming the layer on top will be careful.
This becomes more important when we permit 64-bit lengths which are
even more likely to have the potential for attempted denial of service
abuse.

Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Message-ID: <20230608135653.2918540-8-eblake@redhat.com>
Diffstat (limited to 'scripts/decodetree.py')
0 files changed, 0 insertions, 0 deletions