diff options
| author | Peter Maydell <peter.maydell@linaro.org> | 2023-07-25 10:56:51 +0100 |
|---|---|---|
| committer | Peter Maydell <peter.maydell@linaro.org> | 2023-07-25 10:56:51 +0100 |
| commit | f9540bb1b2d35d2b0f7e831208c5f44854896cd0 (patch) | |
| tree | 18380a0ffc632cec4baca275e77c1c26d7ceb66c /scripts/git-submodule.sh | |
| parent | c6445544d4cea2628fbad3bad09f3d3a03c749d3 (diff) | |
| download | focaccia-qemu-f9540bb1b2d35d2b0f7e831208c5f44854896cd0.tar.gz focaccia-qemu-f9540bb1b2d35d2b0f7e831208c5f44854896cd0.zip | |
scripts/git-submodule.sh: Don't rely on non-POSIX 'read' behaviour
The POSIX definition of the 'read' utility requires that you
specify the variable name to set; omitting the name and
having it default to 'REPLY' is a bashism. If your system
sh is dash, then it will print an error message during build:
qemu/pc-bios/s390-ccw/../../scripts/git-submodule.sh: 106: read: arg count
Specify the variable name explicitly.
Fixes: fdb8fd8cb915647b ("git-submodule: allow partial update of .git-submodule-status")
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-id: 20230720153038.1587196-1-peter.maydell@linaro.org
Diffstat (limited to 'scripts/git-submodule.sh')
| -rwxr-xr-x | scripts/git-submodule.sh | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/scripts/git-submodule.sh b/scripts/git-submodule.sh index 335f7f5fdf..bb1222c772 100755 --- a/scripts/git-submodule.sh +++ b/scripts/git-submodule.sh @@ -103,7 +103,7 @@ update) check_updated $module || echo Updated "$module" done - (while read -r; do + (while read -r REPLY; do for module in $modules; do case $REPLY in *" $module "*) continue 2 ;; |