diff options
| author | Cole Robinson <crobinso@redhat.com> | 2013-08-31 18:36:17 -0400 |
|---|---|---|
| committer | Luiz Capitulino <lcapitulino@redhat.com> | 2013-09-10 10:09:04 -0400 |
| commit | 02dc4bf5684d3fb46786fab2ecff98214b1df9fe (patch) | |
| tree | 0896b9c7cc134a70863ed5a9100af1cd25290850 /scripts/qapi-types.py | |
| parent | 94c2b6aff43cdfcfdfb552773a6b6b973a72ef0b (diff) | |
| download | focaccia-qemu-02dc4bf5684d3fb46786fab2ecff98214b1df9fe.tar.gz focaccia-qemu-02dc4bf5684d3fb46786fab2ecff98214b1df9fe.zip | |
qapi-types.py: Fix enum struct sizes on i686
Unlike other list types, enum wasn't adding any padding, which caused
a mismatch between the generated struct size and GenericList struct
size. More details in a678e26cbe89f7a27cbce794c2c2784571ee9d21
This crashed qemu if calling qmp query-tpm-types for example, which
upsets libvirt capabilities probing. Reproducer on i686:
(sleep 5; printf '{"execute":"qmp_capabilities"}\n{"execute":"query-tpm-types"}\n') | ./i386-softmmu/qemu-system-i386 -S -nodefaults -nographic -M none -qmp stdio
https://bugs.launchpad.net/qemu/+bug/1219207
Cc: qemu-stable@nongnu.org
Signed-off-by: Cole Robinson <crobinso@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Tested-by: Richard W.M. Jones <rjones@redhat.com>
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
Diffstat (limited to 'scripts/qapi-types.py')
| -rw-r--r-- | scripts/qapi-types.py | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/scripts/qapi-types.py b/scripts/qapi-types.py index 86de9800ea..5222463893 100644 --- a/scripts/qapi-types.py +++ b/scripts/qapi-types.py @@ -51,7 +51,10 @@ def generate_fwd_enum_struct(name, members): return mcgen(''' typedef struct %(name)sList { - %(name)s value; + union { + %(name)s value; + uint64_t padding; + }; struct %(name)sList *next; } %(name)sList; ''', |