diff options
| author | Kevin Wolf <kwolf@redhat.com> | 2009-12-02 12:24:42 +0100 |
|---|---|---|
| committer | Anthony Liguori <aliguori@us.ibm.com> | 2009-12-03 11:45:50 -0600 |
| commit | 40ff6d7e8dceca227e7f8a3e8e0d58b2c66d19b4 (patch) | |
| tree | 98d560a0de229f27a66f637cfcadbb1672e68cc3 /slirp/misc.c | |
| parent | 12c09b8ce22d74f78ff50f95676cbe4f501752ae (diff) | |
| download | focaccia-qemu-40ff6d7e8dceca227e7f8a3e8e0d58b2c66d19b4.tar.gz focaccia-qemu-40ff6d7e8dceca227e7f8a3e8e0d58b2c66d19b4.zip | |
Don't leak file descriptors
We're leaking file descriptors to child processes. Set FD_CLOEXEC on file descriptors that don't need to be passed to children to stop this misbehaviour. Signed-off-by: Kevin Wolf <kwolf@redhat.com> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Diffstat (limited to 'slirp/misc.c')
| -rw-r--r-- | slirp/misc.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/slirp/misc.c b/slirp/misc.c index e9f08fdac5..c76ad8fefd 100644 --- a/slirp/misc.c +++ b/slirp/misc.c @@ -132,7 +132,7 @@ fork_exec(struct socket *so, const char *ex, int do_pty) addr.sin_port = 0; addr.sin_addr.s_addr = INADDR_ANY; - if ((s = socket(AF_INET, SOCK_STREAM, 0)) < 0 || + if ((s = qemu_socket(AF_INET, SOCK_STREAM, 0)) < 0 || bind(s, (struct sockaddr *)&addr, addrlen) < 0 || listen(s, 1) < 0) { lprint("Error: inet socket: %s\n", strerror(errno)); @@ -165,7 +165,7 @@ fork_exec(struct socket *so, const char *ex, int do_pty) * Connect to the socket * XXX If any of these fail, we're in trouble! */ - s = socket(AF_INET, SOCK_STREAM, 0); + s = qemu_socket(AF_INET, SOCK_STREAM, 0); addr.sin_addr = loopback_addr; do { ret = connect(s, (struct sockaddr *)&addr, addrlen); |