summary refs log tree commit diff stats
path: root/slirp/slirp.c
diff options
context:
space:
mode:
authorMarc-André Lureau <marcandre.lureau@redhat.com>2018-11-10 17:45:40 +0400
committerSamuel Thibault <samuel.thibault@ens-lyon.org>2019-01-14 00:40:54 +0100
commit2d6cc3d0e77a0d5b4ba4df2cb0d3387881369cfb (patch)
tree68ecea031c7d62da05b68f6b0c2b01f9f750e500 /slirp/slirp.c
parent3ed9f823c688c0dd5dd8d2c936329168c4859d02 (diff)
downloadfocaccia-qemu-2d6cc3d0e77a0d5b4ba4df2cb0d3387881369cfb.tar.gz
focaccia-qemu-2d6cc3d0e77a0d5b4ba4df2cb0d3387881369cfb.zip
slirp: remove unused EMU_RSH
EMU_RSH handling was dropped in commit
0d62c4cfe21752df4c1d6e2c2398f15d5eaa794a.

The assignment, and subsequent free() of ex_ptr->ex_exec to so->extra
looks unsafe (double free is likely to occur).

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Diffstat (limited to 'slirp/slirp.c')
-rw-r--r--slirp/slirp.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/slirp/slirp.c b/slirp/slirp.c
index 0de46084c0..fac7849195 100644
--- a/slirp/slirp.c
+++ b/slirp/slirp.c
@@ -1499,8 +1499,6 @@ static int slirp_state_load(QEMUFile *f, void *opaque, int version_id)
         }
         if (!ex_ptr)
             return -EINVAL;
-
-        so->extra = (void *)ex_ptr->ex_exec;
     }
 
     return vmstate_load_state(f, &vmstate_slirp, slirp, version_id);