diff options
| author | Marc-André Lureau <marcandre.lureau@redhat.com> | 2018-11-10 17:45:40 +0400 |
|---|---|---|
| committer | Samuel Thibault <samuel.thibault@ens-lyon.org> | 2019-01-14 00:40:54 +0100 |
| commit | 2d6cc3d0e77a0d5b4ba4df2cb0d3387881369cfb (patch) | |
| tree | 68ecea031c7d62da05b68f6b0c2b01f9f750e500 /slirp/socket.c | |
| parent | 3ed9f823c688c0dd5dd8d2c936329168c4859d02 (diff) | |
| download | focaccia-qemu-2d6cc3d0e77a0d5b4ba4df2cb0d3387881369cfb.tar.gz focaccia-qemu-2d6cc3d0e77a0d5b4ba4df2cb0d3387881369cfb.zip | |
slirp: remove unused EMU_RSH
EMU_RSH handling was dropped in commit 0d62c4cfe21752df4c1d6e2c2398f15d5eaa794a. The assignment, and subsequent free() of ex_ptr->ex_exec to so->extra looks unsafe (double free is likely to occur). Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com> Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Diffstat (limited to 'slirp/socket.c')
| -rw-r--r-- | slirp/socket.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/slirp/socket.c b/slirp/socket.c index c01d8696af..041ec5061a 100644 --- a/slirp/socket.c +++ b/slirp/socket.c @@ -89,10 +89,6 @@ sofree(struct socket *so) soqfree(so, &slirp->if_fastq); soqfree(so, &slirp->if_batchq); - if (so->so_emu==EMU_RSH && so->extra) { - sofree(so->extra); - so->extra=NULL; - } if (so == slirp->tcp_last_so) { slirp->tcp_last_so = &slirp->tcb; } else if (so == slirp->udp_last_so) { |