diff options
| author | Alex Bennée <alex.bennee@linaro.org> | 2023-12-01 09:36:28 +0000 |
|---|---|---|
| committer | Alex Bennée <alex.bennee@linaro.org> | 2023-12-01 14:11:55 +0000 |
| commit | 9b45cc9931866cedbe46d4372329074595267bfa (patch) | |
| tree | e4300a993dde298e40fc6890090f7f67ee941ae7 /tests/avocado/linux_initrd.py | |
| parent | 5dcf6334ae1af158ec149794c3f35e459b98df5e (diff) | |
| download | focaccia-qemu-9b45cc9931866cedbe46d4372329074595267bfa.tar.gz focaccia-qemu-9b45cc9931866cedbe46d4372329074595267bfa.zip | |
docs/devel: rationalise unstable gitlab tests under FLAKY_TESTS
It doesn't make sense to have two classes of flaky tests. While it may take the constrained environment of CI to trigger failures easily it doesn't mean they don't occasionally happen on developer machines. As CI is the gating factor to passing there is no point developers running the tests locally anyway unless they are trying to fix things. While we are at it update the language in the docs to discourage the QEMU_TEST_FLAKY_TESTS becoming a permanent solution. Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> Reviewed-by: Richard Henderson <richard.henderson@linaro.org> Acked-by: Stefan Hajnoczi <stefanha@redhat.com> Signed-off-by: Alex Bennée <alex.bennee@linaro.org> Message-Id: <20231201093633.2551497-3-alex.bennee@linaro.org>
Diffstat (limited to 'tests/avocado/linux_initrd.py')
| -rw-r--r-- | tests/avocado/linux_initrd.py | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/tests/avocado/linux_initrd.py b/tests/avocado/linux_initrd.py index ba02e5a563..c40a987bd1 100644 --- a/tests/avocado/linux_initrd.py +++ b/tests/avocado/linux_initrd.py @@ -13,7 +13,7 @@ import logging import tempfile from avocado_qemu import QemuSystemTest -from avocado import skipIf +from avocado import skipUnless class LinuxInitrd(QemuSystemTest): @@ -53,7 +53,8 @@ class LinuxInitrd(QemuSystemTest): max_size + 1) self.assertRegex(self.vm.get_log(), expected_msg) - @skipIf(os.getenv('GITLAB_CI'), 'Running on GitLab') + @skipUnless(os.getenv('QEMU_TEST_FLAKY_TESTS'), 'Test is unstable on GitLab') + def test_with_2gib_file_should_work_with_linux_v4_16(self): """ QEMU has supported up to 4 GiB initrd for recent kernel |