diff options
| author | Markus Armbruster <armbru@redhat.com> | 2020-06-30 11:03:29 +0200 |
|---|---|---|
| committer | Markus Armbruster <armbru@redhat.com> | 2020-07-02 06:25:28 +0200 |
| commit | d8da9e71b6c79c2899c08bb168cd0ae88da70596 (patch) | |
| tree | 0965f9b9391d00e65b79e37776f7eb546f14d2d5 /tests/check-qobject.c | |
| parent | 9261ef5e32b0559642ccb70565836e1bc023937e (diff) | |
| download | focaccia-qemu-d8da9e71b6c79c2899c08bb168cd0ae88da70596.tar.gz focaccia-qemu-d8da9e71b6c79c2899c08bb168cd0ae88da70596.zip | |
tests: Use &error_abort where appropriate
Receiving the error in a local variable only to assert there is none is less clear than passing &error_abort. Clean up. Signed-off-by: Markus Armbruster <armbru@redhat.com> Reviewed-by: Thomas Huth <thuth@redhat.com> Message-Id: <20200630090351.1247703-5-armbru@redhat.com>
Diffstat (limited to 'tests/check-qobject.c')
| -rw-r--r-- | tests/check-qobject.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/tests/check-qobject.c b/tests/check-qobject.c index 593c3a0618..6b6deaeb8b 100644 --- a/tests/check-qobject.c +++ b/tests/check-qobject.c @@ -9,6 +9,7 @@ #include "qemu/osdep.h" #include "block/qdict.h" +#include "qapi/error.h" #include "qapi/qmp/qbool.h" #include "qapi/qmp/qdict.h" #include "qapi/qmp/qlist.h" @@ -213,7 +214,6 @@ static void qobject_is_equal_list_test(void) static void qobject_is_equal_dict_test(void) { - Error *local_err = NULL; QDict *dict_0, *dict_1, *dict_cloned; QDict *dict_different_key, *dict_different_value, *dict_different_null_key; QDict *dict_longer, *dict_shorter, *dict_nested; @@ -276,8 +276,7 @@ static void qobject_is_equal_dict_test(void) dict_different_null_key, dict_longer, dict_shorter, dict_nested); - dict_crumpled = qobject_to(QDict, qdict_crumple(dict_1, &local_err)); - g_assert(!local_err); + dict_crumpled = qobject_to(QDict, qdict_crumple(dict_1, &error_abort)); check_equal(dict_crumpled, dict_nested); qdict_flatten(dict_nested); |