summary refs log tree commit diff stats
path: root/tests/functional/test_arm_aspeed_ast2600.py
diff options
context:
space:
mode:
authorDaniel P. Berrangé <berrange@redhat.com>2024-12-17 15:59:29 +0000
committerThomas Huth <thuth@redhat.com>2024-12-17 19:39:53 +0100
commit3d5938607e05c4f8ac6df046a92fad19b681c23b (patch)
treec161ecbdd2ca7805e69bf760965eececa415c0f7 /tests/functional/test_arm_aspeed_ast2600.py
parent3ea06d65be5ee65beabc479d92e964e3c9df5080 (diff)
downloadfocaccia-qemu-3d5938607e05c4f8ac6df046a92fad19b681c23b.tar.gz
focaccia-qemu-3d5938607e05c4f8ac6df046a92fad19b681c23b.zip
tests/functional: switch to new test skip decorators
This ensures consistency of behaviour across all the tests, and requires
that we provide gitlab bug links when marking a test to be skipped due
to unreliability.

Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Message-ID: <20241217155953.3950506-9-berrange@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
Diffstat (limited to 'tests/functional/test_arm_aspeed_ast2600.py')
-rwxr-xr-xtests/functional/test_arm_aspeed_ast2600.py7
1 files changed, 3 insertions, 4 deletions
diff --git a/tests/functional/test_arm_aspeed_ast2600.py b/tests/functional/test_arm_aspeed_ast2600.py
index 74d025e0fc..9c749f96b4 100755
--- a/tests/functional/test_arm_aspeed_ast2600.py
+++ b/tests/functional/test_arm_aspeed_ast2600.py
@@ -11,10 +11,9 @@ import subprocess
 
 from qemu_test import Asset
 from aspeed import AspeedTest
-from qemu_test import exec_command_and_wait_for_pattern
-from qemu_test import has_cmd
+from qemu_test import exec_command_and_wait_for_pattern, skipIfMissingCommands
 from qemu_test.utils import archive_extract
-from unittest import skipUnless
+
 
 class AST2600Machine(AspeedTest):
 
@@ -68,7 +67,7 @@ class AST2600Machine(AspeedTest):
          'images/ast2600-evb/buildroot-2023.02-tpm/flash.img'),
         'a46009ae8a5403a0826d607215e731a8c68d27c14c41e55331706b8f9c7bd997')
 
-    @skipUnless(*has_cmd('swtpm'))
+    @skipIfMissingCommands('swtpm')
     def test_arm_ast2600_evb_buildroot_tpm(self):
         self.set_machine('ast2600-evb')