summary refs log tree commit diff stats
path: root/tests/functional/test_sh4_r2d.py
diff options
context:
space:
mode:
authorDaniel P. Berrangé <berrange@redhat.com>2024-12-17 15:59:29 +0000
committerThomas Huth <thuth@redhat.com>2024-12-17 19:39:53 +0100
commit3d5938607e05c4f8ac6df046a92fad19b681c23b (patch)
treec161ecbdd2ca7805e69bf760965eececa415c0f7 /tests/functional/test_sh4_r2d.py
parent3ea06d65be5ee65beabc479d92e964e3c9df5080 (diff)
downloadfocaccia-qemu-3d5938607e05c4f8ac6df046a92fad19b681c23b.tar.gz
focaccia-qemu-3d5938607e05c4f8ac6df046a92fad19b681c23b.zip
tests/functional: switch to new test skip decorators
This ensures consistency of behaviour across all the tests, and requires
that we provide gitlab bug links when marking a test to be skipped due
to unreliability.

Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Message-ID: <20241217155953.3950506-9-berrange@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
Diffstat (limited to 'tests/functional/test_sh4_r2d.py')
-rwxr-xr-xtests/functional/test_sh4_r2d.py8
1 files changed, 3 insertions, 5 deletions
diff --git a/tests/functional/test_sh4_r2d.py b/tests/functional/test_sh4_r2d.py
index c3cfff79ad..e2fcde2d6b 100755
--- a/tests/functional/test_sh4_r2d.py
+++ b/tests/functional/test_sh4_r2d.py
@@ -4,11 +4,8 @@
 #
 # SPDX-License-Identifier: GPL-2.0-or-later
 
-import os
-
-from qemu_test import LinuxKernelTest, Asset
+from qemu_test import LinuxKernelTest, Asset, skipFlakyTest
 from qemu_test.utils import archive_extract
-from unittest import skipUnless
 
 class R2dTest(LinuxKernelTest):
 
@@ -18,7 +15,8 @@ class R2dTest(LinuxKernelTest):
 
     # This test has a 6-10% failure rate on various hosts that look
     # like issues with a buggy kernel.
-    @skipUnless(os.getenv('QEMU_TEST_FLAKY_TESTS'), 'Test is unstable')
+    # XXX file tracking bug
+    @skipFlakyTest(bug_url=None)
     def test_r2d(self):
         self.set_machine('r2d')
         file_path = self.ASSET_DAY09.fetch()