summary refs log tree commit diff stats
path: root/tests/plugin/insn.c
diff options
context:
space:
mode:
authorRichard Henderson <richard.henderson@linaro.org>2023-06-10 10:19:59 -0700
committerRichard Henderson <richard.henderson@linaro.org>2023-06-26 17:33:00 +0200
commitea185a557bc97868f3729060ea1cd003dbd971d1 (patch)
tree8e38e8805abf4501f1a119a0354e42b5f2d91975 /tests/plugin/insn.c
parent1d3daf95254d998b91445c48de875796df3b0998 (diff)
downloadfocaccia-qemu-ea185a557bc97868f3729060ea1cd003dbd971d1.tar.gz
focaccia-qemu-ea185a557bc97868f3729060ea1cd003dbd971d1.zip
tests/plugin: Remove duplicate insn log from libinsn.so
This is a perfectly natural occurrence for x86 "rep movb",
where the "rep" prefix forms a counted loop of the one insn.

During the tests/tcg/multiarch/memory test, this logging is
triggered over 350000 times.  Within the context of cross-i386-tci
build, which is already slow by nature, the logging is sufficient
to push the test into timeout.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Diffstat (limited to 'tests/plugin/insn.c')
-rw-r--r--tests/plugin/insn.c9
1 files changed, 1 insertions, 8 deletions
diff --git a/tests/plugin/insn.c b/tests/plugin/insn.c
index cd5ea5d4ae..9bd6e44f73 100644
--- a/tests/plugin/insn.c
+++ b/tests/plugin/insn.c
@@ -19,7 +19,6 @@ QEMU_PLUGIN_EXPORT int qemu_plugin_version = QEMU_PLUGIN_VERSION;
 #define MAX_CPUS 8 /* lets not go nuts */
 
 typedef struct {
-    uint64_t last_pc;
     uint64_t insn_count;
 } InstructionCount;
 
@@ -51,13 +50,7 @@ static void vcpu_insn_exec_before(unsigned int cpu_index, void *udata)
 {
     unsigned int i = cpu_index % MAX_CPUS;
     InstructionCount *c = &counts[i];
-    uint64_t this_pc = GPOINTER_TO_UINT(udata);
-    if (this_pc == c->last_pc) {
-        g_autofree gchar *out = g_strdup_printf("detected repeat execution @ 0x%"
-                                                PRIx64 "\n", this_pc);
-        qemu_plugin_outs(out);
-    }
-    c->last_pc = this_pc;
+
     c->insn_count++;
 }