summary refs log tree commit diff stats
path: root/tests/test-bdrv-graph-mod.c
diff options
context:
space:
mode:
authorVladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>2021-02-02 15:49:44 +0300
committerEric Blake <eblake@redhat.com>2021-02-12 15:39:44 -0600
commit934aee14d36e67468260635af61c387227cdaf78 (patch)
treebaa87d2a9264822f6fe7ebcd71f5523ff989a9df /tests/test-bdrv-graph-mod.c
parenta1e708fcda5eab10c866a7d6a4fad4f80b69ad15 (diff)
downloadfocaccia-qemu-934aee14d36e67468260635af61c387227cdaf78.tar.gz
focaccia-qemu-934aee14d36e67468260635af61c387227cdaf78.zip
block: use return status of bdrv_append()
Now bdrv_append returns status and we can drop all the local_err things
around it.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Alberto Garcia <berto@igalia.com>
Message-Id: <20210202124956.63146-3-vsementsov@virtuozzo.com>
Signed-off-by: Eric Blake <eblake@redhat.com>
Diffstat (limited to 'tests/test-bdrv-graph-mod.c')
-rw-r--r--tests/test-bdrv-graph-mod.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/tests/test-bdrv-graph-mod.c b/tests/test-bdrv-graph-mod.c
index 8cff13830e..c4f7d16039 100644
--- a/tests/test-bdrv-graph-mod.c
+++ b/tests/test-bdrv-graph-mod.c
@@ -101,7 +101,7 @@ static BlockDriverState *pass_through_node(const char *name)
  */
 static void test_update_perm_tree(void)
 {
-    Error *local_err = NULL;
+    int ret;
 
     BlockBackend *root = blk_new(qemu_get_aio_context(),
                                  BLK_PERM_WRITE | BLK_PERM_CONSISTENT_READ,
@@ -114,8 +114,8 @@ static void test_update_perm_tree(void)
     bdrv_attach_child(filter, bs, "child", &child_of_bds,
                       BDRV_CHILD_FILTERED | BDRV_CHILD_PRIMARY, &error_abort);
 
-    bdrv_append(filter, bs, &local_err);
-    error_free_or_abort(&local_err);
+    ret = bdrv_append(filter, bs, NULL);
+    g_assert_cmpint(ret, <, 0);
 
     blk_unref(root);
 }