summary refs log tree commit diff stats
path: root/tests/test-vmstate.c
diff options
context:
space:
mode:
authorChen Qun <kuhn.chenqun@huawei.com>2020-02-20 21:41:03 +0800
committerJuan Quintela <quintela@redhat.com>2020-02-28 09:25:49 +0100
commita6fbd637557a850fa22a5527c896d990c4b4d60f (patch)
tree48b63d8fc7c84b5bc3f5b91cbc1931defa8ff6a1 /tests/test-vmstate.c
parent600fe89d6e627a18a01f4b7aef15d84efdb81548 (diff)
downloadfocaccia-qemu-a6fbd637557a850fa22a5527c896d990c4b4d60f.tar.gz
focaccia-qemu-a6fbd637557a850fa22a5527c896d990c4b4d60f.zip
test-vmstate: Fix memleaks in test_load_qlist
There is memleak in test_load_qlist().It's not a big deal,
but test-vmstate will fail if sanitizers is enabled.

In addition, "ret" is written twice with the same value
 in test_gtree_load_iommu().

Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Laurent Vivier <lvivier@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
Diffstat (limited to '')
-rw-r--r--tests/test-vmstate.c6
1 files changed, 2 insertions, 4 deletions
diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c
index cea363dd69..f7b3868881 100644
--- a/tests/test-vmstate.c
+++ b/tests/test-vmstate.c
@@ -1241,7 +1241,6 @@ static void test_gtree_load_iommu(void)
     TestGTreeIOMMU *orig_iommu = create_iommu();
     QEMUFile *fsave, *fload;
     char eof;
-    int ret;
 
     fsave = open_test_file(true);
     qemu_put_buffer(fsave, iommu_dump, sizeof(iommu_dump));
@@ -1250,10 +1249,8 @@ static void test_gtree_load_iommu(void)
 
     fload = open_test_file(false);
     vmstate_load_state(fload, &vmstate_iommu, dest_iommu, 1);
-    ret = qemu_file_get_error(fload);
     eof = qemu_get_byte(fload);
-    ret = qemu_file_get_error(fload);
-    g_assert(!ret);
+    g_assert(!qemu_file_get_error(fload));
     g_assert_cmpint(orig_iommu->id, ==, dest_iommu->id);
     g_assert_cmpint(eof, ==, QEMU_VM_EOF);
 
@@ -1395,6 +1392,7 @@ static void test_load_qlist(void)
     compare_containers(orig_container, dest_container);
     free_container(orig_container);
     free_container(dest_container);
+    qemu_fclose(fload);
 }
 
 typedef struct TmpTestStruct {