diff options
| author | Daniel P. Berrangé <berrange@redhat.com> | 2018-05-14 18:19:13 +0100 |
|---|---|---|
| committer | Paolo Bonzini <pbonzini@redhat.com> | 2018-07-17 16:24:50 +0200 |
| commit | 0c2f6e7ee99517449b4ed6cf333c2d9456d8fe35 (patch) | |
| tree | 8d91c30846fa43898c8e69dddd1ba909eaad4d35 /util/qemu-option.c | |
| parent | f8da93a0ffa09268815c1942732cbc616a7db847 (diff) | |
| download | focaccia-qemu-0c2f6e7ee99517449b4ed6cf333c2d9456d8fe35.tar.gz focaccia-qemu-0c2f6e7ee99517449b4ed6cf333c2d9456d8fe35.zip | |
opts: remove redundant check for NULL parameter
No callers of get_opt_value() pass in a NULL for the "value" parameter, so the check is redundant. Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> Message-Id: <20180514171913.17664-4-berrange@redhat.com> Reviewed-by: Eduardo Habkost <ehabkost@redhat.com> Tested-by: Roman Kagan <rkagan@virtuozzo.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'util/qemu-option.c')
| -rw-r--r-- | util/qemu-option.c | 12 |
1 files changed, 4 insertions, 8 deletions
diff --git a/util/qemu-option.c b/util/qemu-option.c index 834217fc75..01886efe90 100644 --- a/util/qemu-option.c +++ b/util/qemu-option.c @@ -75,20 +75,16 @@ const char *get_opt_value(const char *p, char **value) size_t capacity = 0, length; const char *offset; - if (value) { - *value = NULL; - } + *value = NULL; while (1) { offset = qemu_strchrnul(p, ','); length = offset - p; if (*offset != '\0' && *(offset + 1) == ',') { length++; } - if (value) { - *value = g_renew(char, *value, capacity + length + 1); - strncpy(*value + capacity, p, length); - (*value)[capacity + length] = '\0'; - } + *value = g_renew(char, *value, capacity + length + 1); + strncpy(*value + capacity, p, length); + (*value)[capacity + length] = '\0'; capacity += length; if (*offset == '\0' || *(offset + 1) != ',') { |