summary refs log tree commit diff stats
path: root/util/qemu-timer.c
diff options
context:
space:
mode:
authorPaolo Bonzini <pbonzini@redhat.com>2018-02-06 18:37:39 +0100
committerPaolo Bonzini <pbonzini@redhat.com>2019-08-20 17:26:20 +0200
commit9458a9a1df1a4c719e24512394d548c1fc7abd22 (patch)
tree2e7dd0685486a403fda9fb52c70406a04637ef8b /util/qemu-timer.c
parent1e8a98b53867f61da9ca09f411288e2085d323c4 (diff)
downloadfocaccia-qemu-9458a9a1df1a4c719e24512394d548c1fc7abd22.tar.gz
focaccia-qemu-9458a9a1df1a4c719e24512394d548c1fc7abd22.zip
memory: fix race between TCG and accesses to dirty bitmap
There is a race between TCG and accesses to the dirty log:

      vCPU thread                  reader thread
      -----------------------      -----------------------
      TLB check -> slow path
        notdirty_mem_write
          write to RAM
          set dirty flag
                                   clear dirty flag
      TLB check -> fast path
                                   read memory
        write to RAM

Fortunately, in order to fix it, no change is required to the
vCPU thread.  However, the reader thread must delay the read after
the vCPU thread has finished the write.  This can be approximated
conservatively by run_on_cpu, which waits for the end of the current
translation block.

A similar technique is used by KVM, which has to do a synchronous TLB
flush after doing a test-and-clear of the dirty-page flags.

Reported-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'util/qemu-timer.c')
0 files changed, 0 insertions, 0 deletions