summary refs log tree commit diff stats
path: root/util
diff options
context:
space:
mode:
authorStefan Hajnoczi <stefanha@redhat.com>2017-11-06 19:02:33 +0000
committerStefan Hajnoczi <stefanha@redhat.com>2017-11-08 09:22:55 +0000
commitfb0c43f34eed8b18678c6e1f481d8564b35c99ed (patch)
tree1901a8e7d582ec492a656c37da9586d9e151e8c5 /util
parentb0fbe46ad82982b289a44ee2495b59b0bad8a842 (diff)
downloadfocaccia-qemu-fb0c43f34eed8b18678c6e1f481d8564b35c99ed.tar.gz
focaccia-qemu-fb0c43f34eed8b18678c6e1f481d8564b35c99ed.zip
tests-aio-multithread: fix /aio/multi/schedule race condition
test_multi_co_schedule_entry() set to_schedule[id] in the final loop
iteration before terminating the coroutine.  There is a race condition
where the main thread attempts to enter the terminating or terminated
coroutine when signalling coroutines to stop:

  atomic_mb_set(&now_stopping, true);
  for (i = 0; i < NUM_CONTEXTS; i++) {
      ctx_run(i, finish_cb, NULL);  <--- enters dead coroutine!
      to_schedule[i] = NULL;
  }

Make sure only to set to_schedule[id] if this coroutine really needs to
be scheduled!

Reported-by: "R.Nageswara Sastry" <nasastry@in.ibm.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-id: 20171106190233.1175-1-stefanha@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Diffstat (limited to 'util')
0 files changed, 0 insertions, 0 deletions