From 86100290cb6600b3d65e0794b45c1b82ead99411 Mon Sep 17 00:00:00 2001 From: Marc-André Lureau Date: Mon, 10 Sep 2018 17:49:46 +0400 Subject: hostmem: no need to check for host_memory_backend_mr_inited() in alloc() MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit memfd_backend_memory_alloc/file_backend_memory_alloc both needlessly are are calling host_memory_backend_mr_inited() which creates an illusion that alloc could be called multiple times but it isn't, it's called once from UserCreatable complete(). Suggested-by: Igor Mammedov Signed-off-by: Marc-André Lureau Reviewed-by: Igor Mammedov Signed-off-by: Paolo Bonzini --- backends/hostmem-memfd.c | 4 ---- 1 file changed, 4 deletions(-) (limited to 'backends/hostmem-memfd.c') diff --git a/backends/hostmem-memfd.c b/backends/hostmem-memfd.c index 1c3579e8ab..2eb9c827a5 100644 --- a/backends/hostmem-memfd.c +++ b/backends/hostmem-memfd.c @@ -44,10 +44,6 @@ memfd_backend_memory_alloc(HostMemoryBackend *backend, Error **errp) return; } - if (host_memory_backend_mr_inited(backend)) { - return; - } - backend->force_prealloc = mem_prealloc; fd = qemu_memfd_create(TYPE_MEMORY_BACKEND_MEMFD, backend->size, m->hugetlb, m->hugetlbsize, m->seal ? -- cgit 1.4.1