From cdcb78dba4d2c52bc80c37c2149e0a090ab6a6b2 Mon Sep 17 00:00:00 2001 From: Pierrick Bouvier Date: Tue, 10 Sep 2024 15:15:55 -0700 Subject: hw/misc: remove break after g_assert_not_reached() MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Use of assert(false) can trip spurious control flow warnings from some versions of GCC (i.e. using -fsanitize=thread with gcc-12): error: control reaches end of non-void function [-Werror=return-type] default: g_assert_not_reached(); break; | ^^^^^ Solve that by removing the unreachable 'break' statement, unifying the code base on g_assert_not_reached() instead. Signed-off-by: Pierrick Bouvier Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-ID: <20240910221606.1817478-29-pierrick.bouvier@linaro.org> [PMD: Add description suggested by Eric Blake] Signed-off-by: Philippe Mathieu-Daudé --- hw/misc/imx6_ccm.c | 1 - 1 file changed, 1 deletion(-) (limited to 'hw/misc/imx6_ccm.c') diff --git a/hw/misc/imx6_ccm.c b/hw/misc/imx6_ccm.c index 4b23ef19cd..7d522ed7c5 100644 --- a/hw/misc/imx6_ccm.c +++ b/hw/misc/imx6_ccm.c @@ -301,7 +301,6 @@ static uint64_t imx6_analog_get_periph_clk(IMX6CCMState *dev) default: /* We should never get there */ g_assert_not_reached(); - break; } trace_imx6_analog_get_periph_clk(freq); -- cgit 1.4.1