From 7a608f562ebd91e811ed0b725e528c894e4f19c4 Mon Sep 17 00:00:00 2001 From: Stefan Weil Date: Sun, 23 Sep 2012 08:51:01 +0200 Subject: hw: Fix return value check for bdrv_read, bdrv_write Those functions return -errno in case of an error. The old code would typically only detect EPERM (1) errors. Signed-off-by: Stefan Weil Signed-off-by: Stefan Hajnoczi --- hw/onenand.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'hw/onenand.c') diff --git a/hw/onenand.c b/hw/onenand.c index db6af682c4..0f7b755a6d 100644 --- a/hw/onenand.c +++ b/hw/onenand.c @@ -351,7 +351,7 @@ static inline int onenand_erase(OneNANDState *s, int sec, int num) for (; num > 0; num--, sec++) { if (s->bdrv_cur) { int erasesec = s->secs_cur + (sec >> 5); - if (bdrv_write(s->bdrv_cur, sec, blankbuf, 1)) { + if (bdrv_write(s->bdrv_cur, sec, blankbuf, 1) < 0) { goto fail; } if (bdrv_read(s->bdrv_cur, erasesec, tmpbuf, 1) < 0) { -- cgit 1.4.1