From 8e86b93c2b69a7369aa62a6daec203fe5e757497 Mon Sep 17 00:00:00 2001 From: Paolo Bonzini Date: Mon, 9 Jul 2012 12:06:28 +0200 Subject: scsi: add free_request callback Most device models have a simple lifecycle for the hba_private field and they can free it when a request is completed or cancelled. However, in some cases it may be simpler to tie the lifetime of hba_private to that of the included SCSIRequest. This patch adds a free_request callback to SCSIBusInfo that lets an HBA device model do exactly that. Normally, device models use req->hba_private == NULL to flag requests that have been completed already. Device models that use free_request will still need to track this using a flag. This is the reason why "converting" existing HBAs to use free_request adds complexity and makes little sense. It is simply an additional convenience that is provided by the SCSI layer. USB-attached storage will be the first user. Signed-off-by: Paolo Bonzini Signed-off-by: Gerd Hoffmann --- hw/scsi.h | 1 + 1 file changed, 1 insertion(+) (limited to 'hw/scsi.h') diff --git a/hw/scsi.h b/hw/scsi.h index 76f06d41de..367a346020 100644 --- a/hw/scsi.h +++ b/hw/scsi.h @@ -134,6 +134,7 @@ struct SCSIBusInfo { void (*save_request)(QEMUFile *f, SCSIRequest *req); void *(*load_request)(QEMUFile *f, SCSIRequest *req); + void (*free_request)(SCSIBus *bus, void *priv); }; #define TYPE_SCSI_BUS "SCSI" -- cgit 1.4.1