From 81a322d4a1b68d47908a6630bf22897a289722aa Mon Sep 17 00:00:00 2001 From: Gerd Hoffmann Date: Fri, 14 Aug 2009 10:36:05 +0200 Subject: qdev: add return value to init() callbacks. Sorry folks, but it has to be. One more of these invasive qdev patches. We have a serious design bug in the qdev interface: device init callbacks can't signal failure because the init() callback has no return value. This patch fixes it. We have already one case in-tree where this is needed: Try -device virtio-blk-pci (without drive= specified) and watch qemu segfault. This patch fixes it. With usb+scsi being converted to qdev we'll get more devices where the init callback can fail for various reasons. Signed-off-by: Gerd Hoffmann Signed-off-by: Anthony Liguori --- hw/xilinx_intc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'hw/xilinx_intc.c') diff --git a/hw/xilinx_intc.c b/hw/xilinx_intc.c index 2ecf962ccd..8ef6474fba 100644 --- a/hw/xilinx_intc.c +++ b/hw/xilinx_intc.c @@ -145,7 +145,7 @@ static void irq_handler(void *opaque, int irq, int level) update_irq(p); } -static void xilinx_intc_init(SysBusDevice *dev) +static int xilinx_intc_init(SysBusDevice *dev) { struct xlx_pic *p = FROM_SYSBUS(typeof (*p), dev); int pic_regs; @@ -155,6 +155,7 @@ static void xilinx_intc_init(SysBusDevice *dev) pic_regs = cpu_register_io_memory(pic_read, pic_write, p); sysbus_init_mmio(dev, R_MAX * 4, pic_regs); + return 0; } static SysBusDeviceInfo xilinx_intc_info = { -- cgit 1.4.1