From c0e6b8b798bee5d8772ca8db19638ec89b47c946 Mon Sep 17 00:00:00 2001 From: Alex Bennée Date: Thu, 16 Jan 2025 16:02:39 +0000 Subject: system: propagate Error to gdbserver_start (and other device setups) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This started as a clean-up to properly pass a Error handler to the gdbserver_start so we could do the right thing for command line and HMP invocations. Now that we have cleaned up foreach_device_config_or_exit() in earlier patches we can further simplify by it by passing &error_fatal instead of checking the return value. Having a return value is still useful for HMP though so tweak the return to use a simple bool instead. Reviewed-by: Pierrick Bouvier Acked-by: Ilya Leoshkevich Signed-off-by: Alex Bennée Message-Id: <20250116160306.1709518-11-alex.bennee@linaro.org> --- include/exec/gdbstub.h | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) (limited to 'include/exec/gdbstub.h') diff --git a/include/exec/gdbstub.h b/include/exec/gdbstub.h index d73f424f56..0675b0b646 100644 --- a/include/exec/gdbstub.h +++ b/include/exec/gdbstub.h @@ -49,12 +49,18 @@ void gdb_unregister_coprocessor_all(CPUState *cpu); /** * gdbserver_start: start the gdb server * @port_or_device: connection spec for gdb + * @errp: error handle * * For CONFIG_USER this is either a tcp port or a path to a fifo. For * system emulation you can use a full chardev spec for your gdbserver * port. + * + * The error handle should be either &error_fatal (for start-up) or + * &error_warn (for QMP/HMP initiated sessions). + * + * Returns true when server successfully started. */ -int gdbserver_start(const char *port_or_device); +bool gdbserver_start(const char *port_or_device, Error **errp); /** * gdb_feature_builder_init() - Initialize GDBFeatureBuilder. -- cgit 1.4.1