From 117221ad999a3d027d38ae9ddbaa94d4e1d6a303 Mon Sep 17 00:00:00 2001 From: Fabiano Rosas Date: Mon, 9 Dec 2024 17:44:23 -0300 Subject: tests/qtest/migration: Initialize buffer in probe_o_direct_support MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Valgrind complains about the probe_o_direct_support() function reading from an uninitialized buffer. For probing O_DIRECT support we don't actually need to write to the file, just make sure the pwrite call doesn't reject the write. Still, write zeroes to the buffer to suppress the warning. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Peter Xu Message-Id: <20241209204427.17763-3-farosas@suse.de> Signed-off-by: Fabiano Rosas --- tests/qtest/migration/migration-util.c | 1 + 1 file changed, 1 insertion(+) (limited to 'tests/qtest/migration/migration-util.c') diff --git a/tests/qtest/migration/migration-util.c b/tests/qtest/migration/migration-util.c index 525bf1eed4..401fe27f00 100644 --- a/tests/qtest/migration/migration-util.c +++ b/tests/qtest/migration/migration-util.c @@ -284,6 +284,7 @@ bool probe_o_direct_support(const char *tmpfs) buf = qemu_try_memalign(len, len); g_assert(buf); + memset(buf, 0, len); ret = pwrite(fd, buf, len, offset); unlink(filename); -- cgit 1.4.1 From 06056ef1ff1e457787d277796bff927f51c092c9 Mon Sep 17 00:00:00 2001 From: Fabiano Rosas Date: Wed, 18 Dec 2024 16:22:22 -0300 Subject: tests/qtest/migration: Re-enable postcopy tests Postcopy tests have been inadvertently disabled since commit 124a3c58b8 ("tests/qtest/migration: Move ufd_version_check to utils"). That commit moved the ufd_version_check() function to another file but failed to make sense of the ifdefs and includes: The include was incorrectly dropped. It is needed to pull in for __NR_userfaultfd. The was moved under the wrong ifdef. Fixes: 124a3c58b8 ("tests/qtest/migration: Move ufd_version_check to utils") Reviewed-by: Peter Xu Signed-off-by: Fabiano Rosas Message-Id: <20241218192223.10551-2-farosas@suse.de> --- tests/qtest/migration/migration-util.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'tests/qtest/migration/migration-util.c') diff --git a/tests/qtest/migration/migration-util.c b/tests/qtest/migration/migration-util.c index 401fe27f00..526bed74ea 100644 --- a/tests/qtest/migration/migration-util.c +++ b/tests/qtest/migration/migration-util.c @@ -22,6 +22,11 @@ #include "migration/bootfile.h" #include "migration/migration-util.h" +#if defined(__linux__) +#include +#include +#endif + /* for uffd_version_check() */ #if defined(__linux__) && defined(__NR_userfaultfd) && defined(CONFIG_EVENTFD) #include @@ -31,7 +36,6 @@ /* For dirty ring test; so far only x86_64 is supported */ #if defined(__linux__) && defined(HOST_X86_64) #include "linux/kvm.h" -#include #endif -- cgit 1.4.1