summary refs log tree commit diff stats
path: root/gitlab/issues/target_sparc/host_missing/accel_missing/2319.toml
diff options
context:
space:
mode:
authorChristian Krinitsin <mail@krinitsin.com>2025-05-21 21:21:26 +0200
committerChristian Krinitsin <mail@krinitsin.com>2025-05-21 21:21:26 +0200
commit4b927bc37359dec23f67d3427fc982945f24f404 (patch)
tree245449ef9146942dc7fffd0235b48b7e70a00bf2 /gitlab/issues/target_sparc/host_missing/accel_missing/2319.toml
parentaa8bd79cec7bf6790ddb01d156c2ef2201abbaab (diff)
downloadqemu-analysis-4b927bc37359dec23f67d3427fc982945f24f404.tar.gz
qemu-analysis-4b927bc37359dec23f67d3427fc982945f24f404.zip
add gitlab issues in toml format
Diffstat (limited to 'gitlab/issues/target_sparc/host_missing/accel_missing/2319.toml')
-rw-r--r--gitlab/issues/target_sparc/host_missing/accel_missing/2319.toml29
1 files changed, 29 insertions, 0 deletions
diff --git a/gitlab/issues/target_sparc/host_missing/accel_missing/2319.toml b/gitlab/issues/target_sparc/host_missing/accel_missing/2319.toml
new file mode 100644
index 000000000..a901029e5
--- /dev/null
+++ b/gitlab/issues/target_sparc/host_missing/accel_missing/2319.toml
@@ -0,0 +1,29 @@
+id = 2319
+title = "SPARC32-bit SDIV of negative divisor gives wrong result"
+state = "closed"
+created_at = "2024-04-30T01:02:36.888Z"
+closed_at = "2024-06-23T12:33:26.420Z"
+labels = ["target: sparc", "workflow::Patch available"]
+url = "https://gitlab.com/qemu-project/qemu/-/issues/2319"
+host-os = "- any -"
+host-arch = "- QEMU flavor:"
+qemu-version = "9.0.00"
+guest-os = "- OS/kernel version:"
+guest-arch = "SPARC"
+description = """SDIV of negative divisor gives wrong result because of typo in helper_sdiv(). This is true for QEMU 9.0.0 and earlier.
+
+Place -1 in the Y register and -128 in another reg, then -120 in another register and do SDIV into a result register, instead of the proper value of 1 for the result, the incorrect value of 0 is produced.
+
+There is a typo in target/sparc/helper.c that causes the divisor to be consider unsigned, this patch fixes it:
+
+\\*\\*\\* helper.c.ori Tue Apr 23 16:23:45 2024 --- helper.c Mon Apr 29 20:14:07 2024
+
+---
+
+\\*\\*\\* 121,127 \\*\\*\\*\\* return (uint32_t)(b32 \\< 0 ? INT32_MAX : INT32_MIN) | (-1ull \\<\\< 32); }
+
+! a64 /= b; r = a64; if (unlikely(r != a64)) { return (uint32_t)(a64 \\< 0 ? INT32_MIN : INT32_MAX) | (-1ull \\<\\< 32); --- 121,127 ---- return (uint32_t)(b32 \\< 0 ? INT32_MAX : INT32_MIN) | (-1ull \\<\\< 32); }
+
+! a64 /= b32; r = a64; if (unlikely(r != a64)) { return (uint32_t)(a64 \\< 0 ? INT32_MIN : INT32_MAX) | (-1ull \\<\\< 32);"""
+reproduce = "n/a"
+additional = "n/a"