diff options
Diffstat (limited to 'gitlab/issues/target_arm/host_missing/accel_missing/1938.toml')
| -rw-r--r-- | gitlab/issues/target_arm/host_missing/accel_missing/1938.toml | 48 |
1 files changed, 0 insertions, 48 deletions
diff --git a/gitlab/issues/target_arm/host_missing/accel_missing/1938.toml b/gitlab/issues/target_arm/host_missing/accel_missing/1938.toml deleted file mode 100644 index bfec904cd..000000000 --- a/gitlab/issues/target_arm/host_missing/accel_missing/1938.toml +++ /dev/null @@ -1,48 +0,0 @@ -id = 1938 -title = "[ARM/PL011] Wrong UART register spacing reported in DBG2/SPCR" -state = "closed" -created_at = "2023-10-13T22:29:56.122Z" -closed_at = "2023-11-07T03:01:37.643Z" -labels = ["ACPI", "target: arm"] -url = "https://gitlab.com/qemu-project/qemu/-/issues/1938" -host-os = "n/a" -host-arch = "n/a" -qemu-version = "n/a" -guest-os = "n/a" -guest-arch = "n/a" -description = """QEMU reports the UART address on aarch64 (for PL011 UART) via the ACPI DBG2 and SPCR tables using the ACPI GAS structure. According to MSFT documentation at https://learn.microsoft.com/en-us/windows-hardware/drivers/bringup/acpi-debug-port-table: - -> * The Register Bit Width field contains the register stride and must be a power of 2 that is at least as large as the access size. On 32-bit platforms this value cannot exceed 32. On 64-bit platforms this value cannot exceed 64. -> * The Access Size field is used to determine whether byte, WORD, DWORD, or QWORD accesses are to be used. QWORD accesses are only valid on 64-bit architectures. - -For the PL011, the MMIO registers are: -* spaced 4 bytes apart; therefore the reported bit width should be 32 instead of 8. -* 16 bits wide; therefore the access width should be 2 instead of 1. - -In other words: -``` -diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c -index 6b674231c2..cd284676d7 100644 ---- a/hw/arm/virt-acpi-build.c -+++ b/hw/arm/virt-acpi-build.c -@@ -482,7 +482,7 @@ build_spcr(GArray *table_data, BIOSLinker *linker, VirtMachineState *vms) - build_append_int_noprefix(table_data, 3, 1); /* ARM PL011 UART */ - build_append_int_noprefix(table_data, 0, 3); /* Reserved */ - /* Base Address */ -- build_append_gas(table_data, AML_AS_SYSTEM_MEMORY, 8, 0, 1, -+ build_append_gas(table_data, AML_AS_SYSTEM_MEMORY, 32, 0, 2, - vms->memmap[VIRT_UART].base); - /* Interrupt Type */ - build_append_int_noprefix(table_data, -@@ -673,7 +673,7 @@ build_dbg2(GArray *table_data, BIOSLinker *linker, VirtMachineState *vms) - build_append_int_noprefix(table_data, 34, 2); - - /* BaseAddressRegister[] */ -- build_append_gas(table_data, AML_AS_SYSTEM_MEMORY, 8, 0, 1, -+ build_append_gas(table_data, AML_AS_SYSTEM_MEMORY, 32, 0, 2, - vms->memmap[VIRT_UART].base); - - /* AddressSize[] */ -```""" -reproduce = "n/a" -additional = "n/a" |