summary refs log tree commit diff stats
path: root/gitlab/issues_text/target_missing/host_missing/accel_missing/1460
diff options
context:
space:
mode:
Diffstat (limited to 'gitlab/issues_text/target_missing/host_missing/accel_missing/1460')
-rw-r--r--gitlab/issues_text/target_missing/host_missing/accel_missing/14605
1 files changed, 5 insertions, 0 deletions
diff --git a/gitlab/issues_text/target_missing/host_missing/accel_missing/1460 b/gitlab/issues_text/target_missing/host_missing/accel_missing/1460
new file mode 100644
index 000000000..fe07e0d50
--- /dev/null
+++ b/gitlab/issues_text/target_missing/host_missing/accel_missing/1460
@@ -0,0 +1,5 @@
+block_load fails if last block is included in snapshot and block device isn't multiple of BLK_MIG_BLOCK_SIZE
+Description of problem:
+The `block_load` function in `migration/block.c` has a bug where `blk_pwrite` or `blk_pwrite_zeroes` always write `cluster_size` bytes. If the underlying device is not a multiple of `BLK_MIG_BLOCK_SIZE`, the write will fail with -EIO when trying to write past the end of the device, as `blk_check_byte_request` checks the length of the device.
+
+This can be fixed by ensuring that `cur_addr` + write length passed to `blk_pwrite`/`blk_pwrite_zeroes` never exceeds the total length of the block device.